chore: set ALLOW ORIGIN HEADER on identifier #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes CORS work when e.g. reaching the SPARQL endpoint from a Yasgui instance (like [the one hosted by redpencil](https://yasgui.tools.redpencil.io/)). We could also add this header ONLY to the SPARQL endpoint in the dispatcher but I'm not sure that that's valuable (i.e. we're not doing anything wrong by setting it for the whole app, I think).
|
Tested on Themis test (kal-loebas) that this actually works for Yasgui. |
|
@sergiofenoll we have to do a release soon with the new government domains. |
|
@ValenberghsSven I would be inclined to include it, but it's not blocking and releasing this is just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CORS work when e.g. reaching the SPARQL endpoint from a Yasgui instance (like the one hosted by redpencil).
We could also add this header ONLY to the SPARQL endpoint in the dispatcher but I'm not sure that that's valuable (i.e. we're not doing anything wrong by setting it for the whole app, I think).