-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add loader #1180
feat: Add loader #1180
Conversation
@akloeckner If OK - then please as usual:
|
I've removed an extra check and the feeling of the loader is better and more consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to restart the minor cleanups in separate comments. I felt, it became a bit mixed up in the one long conversation we're having.
😆 Nice commit title... From the theoretical standpoint, this PR looks really great to me now. I'll download and test it again in the coming days. |
Seems great. |
@JulienDeveaux |
Did you test it? I would then trust you and merge it. |
Yeah, a little))))) Will not cause a nuclear war I hope. |
Thanks, guys. This was really a productive night! |
🎉 This PR is included in version 0.13.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements #344 using this style of loader : https://raw.githubusercontent.com/n3r4zzurr0/svg-spinners/main/preview/pulse-black-36.svg