Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out tests were failing because the github
actions/checkout
plugin by default does not download git LFS files. This was causing later tests to fail because they were expecting full test files instead of git LFS pointers.This commit also restores the matrixed snap-atac-flavor options. Each run of the updated workflow will release
default
as well as arecommend-interactive
snapatac2 docker image.Note: tests in this PR are probably failing because it is still pointing at:
kaizhang/SnapATAC2/.github/workflows/docker.yml@main
SnapATAC2/.github/workflows/test_python.yml
Lines 47 to 50 in b785494
Validation:
On my fork, the
Test Docker Image
portion passes. Note that the login step fails (because I didn't set up docker credentials on my fork):https://github.com/njmei/SnapATAC2/actions/runs/8503169951/job/23288304288