Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing docker image builds #282

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix failing docker image builds #282

merged 1 commit into from
Apr 1, 2024

Conversation

njmei
Copy link
Contributor

@njmei njmei commented Apr 1, 2024

  1. It turns out tests were failing because the github actions/checkout plugin by default does not download git LFS files. This was causing later tests to fail because they were expecting full test files instead of git LFS pointers.

  2. This commit also restores the matrixed snap-atac-flavor options. Each run of the updated workflow will release default as well as a recommend-interactive snapatac2 docker image.

Note: tests in this PR are probably failing because it is still pointing at: kaizhang/SnapATAC2/.github/workflows/docker.yml@main

test_docker:
uses: kaizhang/SnapATAC2/.github/workflows/docker.yml@main
with:
version: '2.6.0'

Validation:
On my fork, the Test Docker Image portion passes. Note that the login step fails (because I didn't set up docker credentials on my fork):
https://github.com/njmei/SnapATAC2/actions/runs/8503169951/job/23288304288

1. It turns out tests were failing because the github `actions/checkout`
   plugin by default does not download git LFS files. This was causing
   later tests to fail because they were expecting full test files
   instead of git LFS pointers.

2. This commit also restores the matrixed snap-atac-flavor options.
   Each run of the updated workflow will release `default` as well
   as a `recommend-interactive` snapatac2 docker image.
@njmei
Copy link
Contributor Author

njmei commented Apr 1, 2024

@kaizhang It would probably also be a good idea to prevent external PR requests to accidentally trigger your github actions workflows. It will use up your github actions credits and malicious actors could submit bogus PRs that could hijack the github actions runners to do unsavory things.

I think you can do this by following this guide:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories

Require approval for all outside collaborators. is probably the safest option.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (b785494) to head (e2bf521).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           4        4           
  Lines         227      227           
=======================================
  Hits          223      223           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaizhang kaizhang merged commit 6a319e1 into kaizhang:main Apr 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants