Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed environment variables and added docker secrets for more security #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed environment variables and added docker secrets for more security #20

wants to merge 1 commit into from

Conversation

MauritzFunke
Copy link

No description provided.

kaitallaoua
kaitallaoua reviewed Mar 29, 2024
View reviewed changes
zyspotify/__main__.py
_PASSWORD = os.environ.get("PASSWORD", None)
_USERNAME = None
_PASSWORD = None
with open("/run/secrets/spotify_login") as login:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but can you use pathlib for this purpose. something like json.loads(Path('path/filename').read_text()

kaitallaoua
kaitallaoua requested changes Mar 29, 2024
View reviewed changes
Copy link
Owner

@kaitallaoua kaitallaoua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I still have to test but I like the idea. Only other nitpick is can the json file be called login.json. Its not really a configuration file at present.

@kaitallaoua
Copy link
Owner

Also this currently breaks running the program without docker, as it always tries to load the login file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitallaoua kaitallaoua kaitallaoua requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauritzFunke @kaitallaoua