Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Win32API-based encoding option to C++ runtime #61
Add Win32API-based encoding option to C++ runtime #61
Changes from all commits
2939b29
6e6e7c2
39b3ab7
bcc102f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GreyCat As evidenced by our CI dashboard (https://ci.kaitai.io/), this change breaks half of our tests for target
cpp_stl_11/msvc141_windows_x64
(see kaitai-io/ci_artifacts@cf98b22#diff-ddeb848e50b284745134d0b3371b48f0cf63c52ed1d2f1134ff625c1217b57a3). Theci.json
diff starts as (I simplified it a bit and only showed the first 2 tests that regressed, out of a total of 62):The error is the following (https://ci.appveyor.com/project/kaitai-io/ci-targets/builds/47552134/job/1rj2gtnxn51dxib8?fullLog=true#L492):
Line
compiled/cpp_stl_11/cast_nested.cpp:90
is:But this apparently isn't a MSVC-specific issue. I've just checked
cpp_stl_11/gcc4.8
and the impact looks very much the same (see kaitai-io/ci_artifacts@4ab4ae1#diff-ddeb848e50b284745134d0b3371b48f0cf63c52ed1d2f1134ff625c1217b57a3), again the same 62 regressions in total:The
cpp_stl_11/gcc4.8
target isn't visible at https://ci.kaitai.io/ though, because the CI dashboard is configured to displaycpp_stl_11/gcc4.8_linux
, seesrc/App.vue:63
:I assume pushing to
cpp_stl_11/gcc4.8
was an oversight? I guess keeping the_linux
suffix makes sense - we want to test C++ on different platforms, so it's a good idea to specify the platform in all C++ target names.