Swap a.Variant and a.Flavor to match new artifact naming scheme
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mevatron thanks a lot for the PR, you were right on spot, we changed the artifact name again so this was needed. I just took the freedom to extend your PR because we want to handle the artifact names in the 3 different cases (pre 2.4.0, between 2.4.0 and 2.4.1, and 2.4.2 and beyond). |
Itxaka
reviewed
Nov 15, 2023
Itxaka
approved these changes
Nov 15, 2023
jimmykarily
reviewed
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with the variant and flavor fields being swapped in the new v2.4.2 artifacts, so I created the tiniest of PRs to fix it 😄 If the naming change wasn't intended, feel free to close this PR! I tested these changes locally and they seem to work at least for the ubuntu-20.04 flavor I was testing out.