Infra: Migrate to gradle #783
Conversation
# Conflicts: # api/src/main/java/io/kafbat/ui/service/ApplicationInfoService.java
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi germanosin! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
api/build.gradle
Outdated
|
|
||
| dependencies { | ||
| implementation project(":contract") | ||
| implementation project(":frontend") |
There was a problem hiding this comment.
api shouldn't depend on the frontend
api/build.gradle
Outdated
|
|
||
| checkstyle { | ||
| toolVersion '10.3.1' | ||
| configFile = rootProject.file('etc/checkstyle/checkstyle-e2e.xml') |
There was a problem hiding this comment.
| configFile = rootProject.file('etc/checkstyle/checkstyle-e2e.xml') | |
| configFile = rootProject.file('etc/checkstyle/checkstyle.xml') |
due to e2e having a different rule set
contract/build.gradle
Outdated
|
|
||
| plugins { | ||
| id "java-library" | ||
| id 'org.openapi.generator' version '7.9.0' |
There was a problem hiding this comment.
can we extract this version as well to a version catalog (gradle's "dependency management" list) to make it possible for dependabot to track these versions as well?
e2e-tests/build.gradle
Outdated
|
|
||
| checkstyle { | ||
| toolVersion '10.3.1' | ||
| configFile = rootProject.file('etc/checkstyle/checkstyle.xml') |
There was a problem hiding this comment.
| configFile = rootProject.file('etc/checkstyle/checkstyle.xml') | |
| configFile = rootProject.file('etc/checkstyle/checkstyle-e2e.xml') |
gradle.properties
Outdated
| @@ -0,0 +1,7 @@ | |||
| description='Kafka UI' | |||
There was a problem hiding this comment.
| description='Kafka UI' | |
| description='Kafbat UI' |
| @@ -0,0 +1,103 @@ | |||
| [versions] | |||
There was a problem hiding this comment.
@yeikel I believe this answers your question regarding the version catalog
api/build.gradle
Outdated
| plugins { | ||
| id 'antlr' | ||
| id 'checkstyle' | ||
| id 'org.springframework.boot' version '3.4.1' |
There was a problem hiding this comment.
gradle/libs.versions.toml has 3.3.6
| @@ -0,0 +1,103 @@ | |||
| [versions] | |||
| spring-boot = '3.3.6' | |||
| spring-ldap = '6.3.5' | |||
There was a problem hiding this comment.
why 6.3.2? in maven we don't override this and the current version is 6.4.2
serde-api/build.gradle
Outdated
| // repositories { | ||
| // sonatype { | ||
| // nexusUrl = uri("https://s01.oss.sonatype.org/service/local/") | ||
| // snapshotRepositoryUrl = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") |
| @@ -0,0 +1,2 @@ | |||
| sonatypeUsername=test | |||
There was a problem hiding this comment.
Yes, we need any value to be present during build time
Haarolean
added
scope/backend
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)