Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: FE: limit pnpm and node version enforcement to the major versions #777

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

yeikel
Copy link
Collaborator

@yeikel yeikel commented Jan 14, 2025

This change is a follow up for #747 to only enforce the major versions.

Minor and feature revision enforcement is not necessary and adds little value.

A sample situations where this can hurt us include Dependabot and other tools.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

A picture of a cute animal (not mandatory but encouraged)

8f6f8607d5dc31abd4c457261dff626b

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 14, 2025
@yeikel yeikel changed the title relax version enforcement Infra: FE: relax version enforcement Jan 14, 2025
@yeikel yeikel changed the title Infra: FE: relax version enforcement Infra: FE: limit version enforcement to the major versions Jan 14, 2025
@yeikel yeikel changed the title Infra: FE: limit version enforcement to the major versions Infra: FE: limit pnpm and node version enforcement to the major versions Jan 14, 2025
@yeikel yeikel marked this pull request as ready for review January 14, 2025 15:07
@yeikel yeikel requested a review from a team as a code owner January 14, 2025 15:08
@yeikel yeikel mentioned this pull request Jan 14, 2025
10 tasks
@yeikel yeikel force-pushed the relax-enforcement branch from 2866caa to c381d76 Compare January 14, 2025 19:53
@Haarolean Haarolean added scope/frontend Related to frontend changes type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed status/triage/manual Manual triage in progress labels Jan 15, 2025
@Haarolean Haarolean added this to the 1.2 milestone Jan 15, 2025
@Haarolean Haarolean merged commit ed49499 into kafbat:main Jan 15, 2025
22 of 24 checks passed
@yeikel yeikel deleted the relax-enforcement branch January 15, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/dependencies A pull request/issue dedicated to updating the dependency(-ies)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants