-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: Run cve checks workflow on pull requests and pushes to main #745
base: main
Are you sure you want to change the base?
Conversation
@Haarolean I noticed that you implemented this recently: #219 We probably do not want to send notifications for every failure (definitely not from pull requests). Do you have any suggestion about when should it be sent? For now, I pushed d5a52d3 to only send it from |
Thank you for this PR. |
I addressed this with 94da91b it should be ready to merge now I believe Thanks! |
1144233
to
150b7af
Compare
@Haarolean Anything pending to merge this? |
@@ -1,5 +1,8 @@ | |||
name: "Infra: CVE checks" | |||
on: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one implies specifying types, for example we don't need to re-run this on labeled
event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it with fcd6acb
What changes did you make? (Give an overview)
Closes #707
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Tested here :
main
: https://github.com/yeikel/kafka-ui/actions/runs/12602983150/job/35127088622Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)