Fix can't get pfname for virtio pci path #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeke
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Left a few comment. Not an expert of virtIO, but is there any chance to cover this change via unit tests? See utils_test.go
JasinlikeEatingOrange
force-pushed
the
dev/fix-get-pfname
branch
6 times, most recently
from
2e68d1e
to
c220256
Compare
sorry, i have modify the code and add test case, it passed . thx for review. |
JasinlikeEatingOrange
force-pushed
the
dev/fix-get-pfname
branch
from
c220256
to
c5050b4
Compare
Fixed issue with virtio driver by adding a conditional check for the virtio path under the PCI address, preventing errors when the pf name cannot be found. This ensures successful acquisition of vf resources. Fixes k8snetworkplumbingwg#507 Signed-off-by: JasinlikeEatingOrange <[email protected]>
JasinlikeEatingOrange
force-pushed
the
dev/fix-get-pfname
branch
from
c5050b4
to
6615dfc
Compare
|
/hold |
|
can I close this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with virtio driver by adding a conditional check for the virtio path under the PCI address, preventing errors when the pf name cannot be found. This ensures successful acquisition of vf resources.
Fixes #507