Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HostIFName in DeviceInfo and vfid in PciDevice #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiayoukun
Copy link

1.The addition of these two fields is mainly to adapt to the deviceinfo of more types of network cards, such as veth in Calico and ovs-cni. Among them, ovs-cni has a greater need for this field. It relies on delivering flow tables under the vethName on the host to divert traffic. Adding this field can bind the vethName on the host with the corresponding Pod, eliminating the need to store the mapping between ovs and Pod in a separate database. I will adapt this content in a subsequent ovs-cni PR.

2.In metric monitoring, more information about the VF network card is needed, such as vfid and OrigVfName. I will later add OrigVfName to HostIFName and vfid to vfid in sriov-cni to facilitate reading the Pod's VfName and vfid.

@jiayoukun
Copy link
Author

@s1061123
Can you check this pr and the multus-cni pr for me?
multus-cni-pr

These two pr's allow CNI to implement a flexible deviceinfo.

@s1061123
Copy link
Member

This repository just implements https://github.com/k8snetworkplumbingwg/device-info-spec so we don't additional feature in it without any specification change. To modify this specification, please bring the topic in network plumbing working group meeting.
See https://github.com/k8snetworkplumbingwg/community?tab=readme-ov-file#meetings for the details.

This meeeting is bi-weekly, so next meeting will be May 30th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants