-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping #53
Housekeeping #53
Conversation
11e5463
to
db724c3
Compare
Pull Request Test Coverage Report for Build 5597327953Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
02c01e4
to
3fa911d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8ea6c6c
to
a2067df
Compare
@ykulazhenkov we need to allow github CI actions write access, otherwise hadolint check won't run |
current CI issue is not related to actions permissions
You have bug in the Makefile |
@@ -76,6 +76,14 @@ unit-test: envtest ## Run unit tests. | |||
.PHONY: test | |||
test: lint unit-test ## Run all tests (lint, unit-test). | |||
|
|||
HADOLINT_TOOL = $(BINDIR)/hadolint | |||
$(HADOLINT_TOOL): | $(BASE) ; $(info installing hadolint...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this repo directory for bin files is in BIN_DIR var not in BINDIR
Update golangci-lint and fix lint and test problems Signed-off-by: amaslennikov <[email protected]>
a2067df
to
1f0c705
Compare
Update go to 1.20
Update golangci-lint
Update github actions (static checks, arm64 build)