e2e: Fix logging during test failure #454
Conversation
Signed-off-by: Ram Lavi <[email protected]>
Currently during test fail, the kubemacpool manager pod logs are not printed because the container name is not specified. - Changing method of extracting the logs using req.Stream. - Changing to print all container logs. - Fix minor print formatting. Signed-off-by: Ram Lavi <[email protected]>
In cases where the e2e is run a bigger context (like CNAO tier1 [0]) - The failed tests logger should only catch kubemacpool related tests. Signed-off-by: Ram Lavi <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@oshoval will help us debug the flake we saw on CNAO. PTAL when you have the time |
|
/cherry-pick release-0.45 |
|
@RamLavi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
logs are not printed correctly as shown on #452
This PR is fixing that
Special notes for your reviewer:
Release note: