Skip to content

Commit

Permalink
Remove Pending flag from skipped tests (#138)
Browse files Browse the repository at this point in the history
Removing Pending flag from 2162 regarding issue resolved [1]
and 2165 regarding issue resolved [2].

Those tests were flaky due to an issue with how the manager pods
reported readiness, this caused the manager-pods to raise
"..connection refused" errors right after deletion.

Now that [3] is merged we can continue to use these tests.

[1] #104
[2] #105
[3] #124

Signed-off-by: Or Mergi <[email protected]>
  • Loading branch information
ormergi authored May 10, 2020
1 parent e07182f commit 97e9201
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/virtual_machines_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@ var _ = Describe("Virtual Machines", func() {
Expect(err).ToNot(HaveOccurred())
})
})
//2162 test postponed due to issue: https://github.com/k8snetworkplumbingwg/kubemacpool/issues/104
PContext("When trying to create a VM after all MAC addresses in range have been occupied", func() {
//2162
Context("When trying to create a VM after all MAC addresses in range have been occupied", func() {
It("should return an error because no MAC address is available", func() {
err := initKubemacpoolParams("02:00:00:00:00:00", "02:00:00:00:00:01")
Expect(err).ToNot(HaveOccurred())
Expand All @@ -289,8 +289,8 @@ var _ = Describe("Virtual Machines", func() {
Expect(err).To(HaveOccurred())
})
})
//2165 test postponed due to issue: https://github.com/k8snetworkplumbingwg/kubemacpool/issues/105
PContext("when trying to create a VM after a MAC address has just been released duo to a VM deletion", func() {
//2165
Context("when trying to create a VM after a MAC address has just been released duo to a VM deletion", func() {
It("should re-use the released MAC address for the creation of the new VM and not return an error", func() {
err := initKubemacpoolParams("02:00:00:00:00:00", "02:00:00:00:00:02")
Expect(err).ToNot(HaveOccurred())
Expand Down

0 comments on commit 97e9201

Please sign in to comment.