Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces significant updates to the Multus Helm chart, improving its functionality, simplifying its setup, and aligning it with Helm 3 best practices. Key changes include updating the chart to support the new
multus-thin
entry point, automating configuration, and improving the overall chart logic.Key Changes
Thin Entry Point:
multus-thin
entry point, streamlining the deployment process for this mode.Auto Configuration:
CRD Best Practices:
crds/
directory, adhering to Helm 3 best practices for CRD management.Chart Logic Cleanup:
if
statements withwith
blocks to simplify the chart logic, making it more readable and maintainable.Command Flag Support:
multus-thin
entry point, offering enhanced control over the Multus deployment.Helm Docs Integration:
helm-docs
to automatically generate theREADME.md
file from thevalues.yaml
, ensuring that documentation stays up-to-date with the chart’s configurable values.InitContainer for Installation:
initContainer
, improving the management of Multus binaries and configuration during startup.CI Integration:
Rationale
multus-thin
gives users more control over their Multus configuration.Testing & Validation
Next Steps