New samples #21
Merged
New samples #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 527e64f.
Need to incorporate code from this remote repository in my branch
|
I've had to resolve some conflicts and hope I've managed to capture the most up-to-date code, but we should do another run-through at the end. |
|
I want to double check the population assignments before merging, but this looks good! |
k8hertweck
reviewed
Mar 30, 2018
| @@ -1,3 +1,6 @@ | |||
| SRR655969 | |||
There was a problem hiding this comment.
Why did you include these three samples in the list? They're excluded from the analysis, so it's not clear why we'd need to have them downloaded, etc.
There was a problem hiding this comment.
OK, I see what happened: the numbers aren't sorted from the original sheet, and you've added them in duplicate. I'll take care of this.
double checked DataOverview_Design.csv against the Google Doc and updated file assignments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed the top five tasks of issue #13