-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #164
Merged
Merged
V2 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
exec-runner-refactor
branch
from
January 30, 2024 09:27
e41937b
to
2c7ac91
Compare
kke
added
enhancement
New feature or request
go
Pull requests that update Go code
labels
Jan 31, 2024
kke
force-pushed
the
exec-runner-refactor
branch
4 times, most recently
from
February 10, 2024 19:17
8345ab9
to
0cbf539
Compare
kke
force-pushed
the
exec-runner-refactor
branch
10 times, most recently
from
February 19, 2024 21:05
e83675f
to
0cbcf82
Compare
kke
force-pushed
the
exec-runner-refactor
branch
3 times, most recently
from
February 23, 2024 22:14
d4d105f
to
952e6dc
Compare
kke
force-pushed
the
exec-runner-refactor
branch
from
March 8, 2024 14:26
732f936
to
4f0f9bb
Compare
kke
force-pushed
the
exec-runner-refactor
branch
from
March 10, 2024 20:40
d029853
to
0c68cf7
Compare
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
exec-runner-refactor
branch
2 times, most recently
from
March 10, 2024 22:55
2846eac
to
540912d
Compare
Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
exec-runner-refactor
branch
from
March 10, 2024 23:10
540912d
to
87043bb
Compare
Signed-off-by: Kimmo Lehto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much everything has been changed and touched.
Increased modularity and thus improved extendability, flexibility, testability and component reusability.
Context is finding its way in. There is for example
h.ExecContext(ctx, ...)
andh.Connect(ctx)
.Short summary of changes to usage:
Exec.Sudo() is gone.
There's no more "Execf".
Configurers are gone. You may still need to implement them for your own usecases, but they're no longer in rig. Instead, the functionality has been spread out to different components and more stdlib
os
resembling functionality bundled with thefs.FS
implementation inrig/remotefs
.A great chunk of replicated logic in each of the protocol client implementations was moved to a centralized
cmd.Executor
. The protocols now only need to implement a singleStartProcess
function, all of the output capturing, input relaying and so on is done in the executor.There are a number of io.Writers and io.Readers now used internally for things that were done with string manipulations before. Many of these are reusable for other stuff.
TODO - this PR does not include much refactoring for the connection setup stuff, which has become quite difficult to maintain due to its complexity, especially the SSH. That will be addressed in a separate PR before a final 2.0.0 is tagged.