Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect DNS address computation errors #5236

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 12, 2024

Description

The existing code is unable to compute meaningful DNS addresses if the service CIDR doesn't describe a v4 network. Error out whenever the network IP is not a v4 address until it is clear how to properly compute the DNS address for a v6 network. Also, copy address by value so that changes to it don't change ipnet as well.

See #5223 (comment).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The existing code is unable to compute meaningful DNS addresses if
the service CIDR doesn't describe a v4 network. Error out whenever the
network IP is not a v4 address until it is clear how to properly compute
the DNS address for a v6 network. Also, copy `address` by value so that
changes to it don't change `ipnet` as well.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/configuration labels Nov 12, 2024
@twz123 twz123 mentioned this pull request Nov 12, 2024
16 tasks
@twz123 twz123 added the backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch label Nov 12, 2024
@twz123 twz123 marked this pull request as ready for review November 12, 2024 19:26
@twz123 twz123 requested review from a team as code owners November 12, 2024 19:26
@twz123 twz123 requested review from kke and jnummelin November 12, 2024 19:26
@twz123 twz123 mentioned this pull request Nov 12, 2024
4 tasks
@twz123 twz123 merged commit fa503dd into k0sproject:main Nov 18, 2024
92 checks passed
@twz123 twz123 deleted the dns-address-computation-errors branch November 18, 2024 13:16
@k0s-bot
Copy link

k0s-bot commented Nov 18, 2024

Successfully created backport PR for release-1.31:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants