Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable testifylint linter #5228

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Enable testifylint linter #5228

merged 1 commit into from
Nov 13, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 12, 2024

Description

... and fix lints on the way.

Also add the f suffix for methods that are using format strings. This enables the linting of the strings against their varargs list.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Nov 12, 2024
@twz123 twz123 marked this pull request as ready for review November 12, 2024 15:25
@twz123 twz123 requested review from a team as code owners November 12, 2024 15:25
@twz123 twz123 requested review from kke and makhov November 12, 2024 15:25
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

kke
kke previously approved these changes Nov 13, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Enable testifylint linter
f0827d5 
... and fix lints on the way.

Also add the f suffix for methods that are using format strings. This
enables the linting of the strings against their varargs list.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit d0915d1 into k0sproject:main Nov 13, 2024
89 checks passed
@twz123 twz123 deleted the testifylint branch November 13, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa ncopa approved these changes

@kke kke kke left review comments

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @ncopa @kke