Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prove airgap bundle processing in AP inttest #3936

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 16, 2024

Description

The Autopilot airgap inttest is operating on an already bootstrapped cluster. This means that all the images have already been pulled on the worker as soon as the Autopilot update kicks in. Hence, the update will succeed even if the airgap bundle functionality is broken.

To have an actual proof of correct processing, the inttest now checks the pinning of the images. Before the update, none of them should be pinned, after the update all of them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The Autopilot airgap inttest is operating on an already bootstrapped
cluster. This means that all the images have already been pulled on the
worker as soon as the Autopilot update kicks in. Hence, the update will
succeed even if the airgap bundle functionality is broken.

To have an actual proof of correct processing, the inttest now checks
the pinning of the images. Before the update, none of them should be
pinned, after the update all of them.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review January 17, 2024 07:57
@twz123 twz123 requested a review from a team as a code owner January 17, 2024 07:57
@twz123 twz123 merged commit a189bf9 into k0sproject:main Jan 17, 2024
72 checks passed
@twz123 twz123 deleted the airgap-inttest-fix branch January 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants