Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k0sctl used in tests to v0.17.2 #3897

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Bump k0sctl used in tests to v0.17.2 #3897

merged 1 commit into from
Jan 9, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 8, 2024

Description

Bumps k0sctl in tests to 0.17.2.

There should be a better way than modifying so many files.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Copy link
Member

twz123 commented Jan 8, 2024

There should be a better way than modifying so many files.

We could do something similar as for the other tool versions. But this makes things more complex (additional script invocations, use of placeholders) , and some places will need custom care anyways (e.g. go.mod, go.sum). Not sure if that holds its weight compared to some simple/stupid regex-replace. Probably depends on how often a bump happens. Ideally, some tool could do a fully automated PR. Dependabot cannot do this. Maybe Renovate could do it. But again, this would require quite some plumbing.

@twz123 twz123 merged commit 54912bf into main Jan 9, 2024
110 of 186 checks passed
@twz123 twz123 deleted the k0sctl-0.17.2 branch January 9, 2024 08:16
@kke
Copy link
Contributor Author

kke commented Jan 9, 2024

cd hack/tool; go list -m -f '{{.Version}}' github.com/k0sproject/k0sctl would give the version from go.mod. The rest could somehow get it from there.

@twz123
Copy link
Member

twz123 commented Jan 9, 2024

cd hack/tool; go list -m -f '{{.Version}}' github.com/k0sproject/k0sctl would give the version from go.mod. The rest could somehow get it from there.

That would require a go toolchain just to figure out the k0sctl version number. Would be awkward for e.g. terraform-only stuff.

@kke
Copy link
Contributor Author

kke commented Jan 9, 2024

grep k0sctl hack/tool/go.mod|cut -d" " -f2 :)

@twz123
Copy link
Member

twz123 commented Jan 9, 2024

You can try to cook up something, if you like 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants