Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use footloose fork to fix use ov cgroupv2 for inttests #1505

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Feb 10, 2022

Currently footloose only works with cgroup v1. Use fork for now til this
has be resolved upstream.

Upstream issue: weaveworks/footloose#270
Upstream PR: weaveworks/footloose#272

Signed-off-by: Natanael Copa [email protected]

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Currently footloose only works with cgroup v1. Use fork for now til this
has be resolved upstream.

Upstream issue: weaveworks/footloose#270
Upstream PR: weaveworks/footloose#272

Signed-off-by: Natanael Copa <[email protected]>
@ncopa ncopa requested a review from a team as a code owner February 10, 2022 20:26
@ncopa ncopa requested review from s0j and mviitane February 10, 2022 20:26
@ncopa ncopa merged commit 36a0d12 into k0sproject:main Feb 14, 2022
@ncopa ncopa deleted the footloose-cgroupv2 branch February 14, 2022 14:03
@twz123 twz123 added backport/release-1.21 backport/release-1.22 PR that needs to be backported/cherrypicked to release-1.22 branch area/ci labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci backport/release-1.21 backport/release-1.22 PR that needs to be backported/cherrypicked to release-1.22 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants