Prevent a media from opening a browser

k0kubun · May 3, 2021 · 5bd0edd · 5bd0edd
1 parent 53d3518
commit 5bd0edd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/components/retweet.js b/src/components/retweet.js
@@ -12,7 +12,7 @@ export default class Retweet extends Tweet {
     tab:     PropTypes.string.isRequired,
     tweet:   PropTypes.object.isRequired,
     onClick: PropTypes.func.isRequired,
-    openMediaInWindow: PropTypes.func.isRequired,
+    openMediaInWindow: PropTypes.func.isRequired, // Used in the superclass
   }
 
   render() {

diff --git a/src/components/tweet.js b/src/components/tweet.js
@@ -53,8 +53,11 @@ export default class Tweet extends React.Component {
     return entities.media.map((media) => {
       if (media.type === 'photo' || media.type === 'video' || media.type === 'animated_gif') {
         return (
-          <a href="javascript:void(0);"  key={media.id_str} target='_blank'>
-            <img className='tweet_media' onClick={(event) => {this.props.openMediaInWindow(media)}} src={media.media_url} />
+          <a href='javascript:void(0);' key={media.id_str} target='_blank'>
+            <img className='tweet_media' onClick={ (event) => {
+              event.preventDefault();
+              this.props.openMediaInWindow(media);
+            } } src={media.media_url} />
           </a>
         );
       } else {