Feat / Hero shelf #638
Merged
Feat / Hero shelf #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royschut
requested review from
langemike,
ChristiaanScheermeijer and
CarinaDraganJW
|
Visit the preview URL for this PR (updated for commit 05363af): https://ottwebapp--pr638-feat-hero-shelf-8fj9qvch.web.app (expires Sun, 08 Dec 2024 08:19:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
ChristiaanScheermeijer
approved these changes
Nov 7, 2024
AntonLantukh
reviewed
Nov 7, 2024
royschut
force-pushed
the
feat/hero-shelf
branch
from
ffa1dcc
to
05363af
Compare
langemike
approved these changes
Nov 8, 2024
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat / Hero shelf
This PR:
<HeroShelf />, and makes sure it is only possible on the0index, as this is the only way it makes senseisFeaturedshelf state, the shelf with larger cards, on any positionlayoutTypecustom parameter on the shelves, which can behero,featuredor undefinedfeaturedboolean on the appconfig playlistsSteps completed:
According to our definition of done, I have completed the following steps: