Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for featured custom param #632

Merged

Conversation

CarinaDraganJW
Copy link
Contributor

@CarinaDraganJW CarinaDraganJW commented Nov 4, 2024

Description

  • Support "featured" custom param (featured prop will be deprecated)

This PR solves #OWA-95 .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Nov 4, 2024

Visit the preview URL for this PR (updated for commit b7c7b53):

https://ottwebapp--pr632-feature-owa-95-suppo-vdks0x18.web.app

(expires Wed, 04 Dec 2024 13:17:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@CarinaDraganJW CarinaDraganJW merged commit 9ea7884 into develop Nov 4, 2024
10 checks passed
@CarinaDraganJW CarinaDraganJW deleted the feature/OWA-95.support-featured-custom-param branch November 4, 2024 14:42
This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants