Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access bridge flaky tests #627

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: access bridge flaky tests #627

merged 3 commits into from
Oct 10, 2024

Conversation

kiremitrov123
Copy link
Collaborator

Description

This PR fixes the unit tests on the access bridge side that were causing the workflow to fail from time to time.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Oct 3, 2024

Visit the preview URL for this PR (updated for commit 75a2e10):

https://ottwebapp--pr627-fix-ac-flaky-tests-crk5y0b3.web.app

(expires Sat, 09 Nov 2024 07:33:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

Copy link
Collaborator

@AntonLantukh AntonLantukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into i!

@kiremitrov123 kiremitrov123 merged commit 1ae469b into develop Oct 10, 2024
10 checks passed
@kiremitrov123 kiremitrov123 deleted the fix/ac-flaky-tests branch October 10, 2024 09:59
This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants