Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): support translations for shelves titles and menu labels #612

Merged
merged 17 commits into from
Nov 5, 2024
Merged

feat(i18n): support translations for shelves titles and menu labels #612

merged 17 commits into from
Nov 5, 2024

Conversation

CarinaDraganJW
Copy link
Contributor

Description

  • PR proposal for implementing translations for shelves titles and menu labels

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@CarinaDraganJW CarinaDraganJW added the forming This idea is a brainstorm, green field, or work in progress label Sep 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit fc45cd7):

https://ottwebapp--pr612-feature-support-tran-7fi1tly8.web.app

(expires Wed, 04 Dec 2024 15:56:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

ChristiaanScheermeijer
ChristiaanScheermeijer approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🙌

@ChristiaanScheermeijer
Copy link
Collaborator

Hi @CarinaDraganJW @AntonLantukh, can we merge this PR?

@CarinaDraganJW
Copy link
Contributor Author

CarinaDraganJW commented Nov 1, 2024 •
edited
Loading

Hi @CarinaDraganJW @AntonLantukh, can we merge this PR?

Hi @ChristiaanScheermeijer 👋🏻

I can definitely merge it, sorry it got postponed 🛠️
The only thing that is not working is the "Continue Watching" and "Favourites" shelves translations, but that is because we don't have support to add custom params for these in the dashboard.

Screenshot 2024-11-04 at 15 49 12

However, that is exactly the next thing we will work on, so this problem will be fixed very soon, I don't see an issue not to merge it 🚀

Waiting for @AntonLantukh to approve as well 🙂

@CarinaDraganJW CarinaDraganJW merged commit 8d13515 into develop Nov 5, 2024
10 checks passed
@CarinaDraganJW CarinaDraganJW deleted the feature/support-translations-for-shelves-menu-items branch November 5, 2024 13:36
@royschut royschut mentioned this pull request Nov 6, 2024
Merged
8 tasks
This was referenced Nov 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristiaanScheermeijer ChristiaanScheermeijer ChristiaanScheermeijer approved these changes

@AntonLantukh AntonLantukh Awaiting requested review from AntonLantukh AntonLantukh is a code owner

@dbudzins dbudzins Awaiting requested review from dbudzins dbudzins is a code owner

Assignees
No one assigned
Labels
forming This idea is a brainstorm, green field, or work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarinaDraganJW @ChristiaanScheermeijer