Fix / Read title while searching (accessibility) #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the screen reader to announce the outcome of your search query while your type, to provide convenience for screen reader users. You could consider this a pragmatic typeahead implementation.
Because
aria-live="polite"
is used it is announced after you performed a keystroke.Good to know:
aria-live
to the<ErrorPage>
so that title is also announced. Adding this also made me realize it can also be beneficial in other cases where ErrorPage get rendered.isFetching
-conditions. Though, I think it's more logical to render the placeholder data based on theisFetching
-state itself instead of!!query
. Something to improve in the future.This change is based on feedback we got from our internal accessibility auditor. He noted the following: