#438 - Fix non-anmiated slider #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9bed444): https://ottwebapp--pr437-dbudzins-fix-slider-uxln577u.web.app (expires Sun, 18 Feb 2024 11:04:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
dbudzins
force-pushed
the
dbudzins/fix-slider
branch
from
636c8b8
to
e827aff
Compare
AntonLantukh
approved these changes
Jan 24, 2024
This was referenced Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small logic fix for problem identified with shelf slider (TileDock) in non-animated mode.
This PR solves #438.
Steps completed:
According to our definition of done, I have completed the following steps:
- [ ] Unit tests added- [ ] Docs updated (including config and env variables)- [ ] Translations added