-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: accessibility improvements and bug fixes
* chore: add pr deployment previews workflows * fix(payment): redirect to wrong media after payment * chore: add version number to footer text Co-authored-by: Melissa Hart <[email protected]> * fix: show error on email field when invalid * fix(project): favicons & preconnect jwapp.com * fix: broken checkbox in personal details form * fix: hide disabled questions in personal details screen * fix: improve consents required form error * fix: show error when delete account fails * fix: hide optional label in season select dropdown * fix: shelf margin and grid loading state * chore: add default config and set demo mode on for build (#127) * feat: Render favicons dynamically Co-authored-by: Mike van Veenhuijzen <[email protected]> * refactor(payment): improve choose offer flow * fix(payment): ui not updating after paypal payment * refactor: add strict util for modal urls from window location * feat(a11y): add auto focus to play/pause button of players * fix(menu): prevent text to go on two lines in buttons * fix(a11y): ensure wcag compliance with 1.5 line-height for texts (#109) * feat(a11y): apply the autocomplete attribute to input fields(#115) * feat(a11y): apply correct aria attributes and improve searchbar (#117) * feat(a11y): video meta data items separated (#116) Co-authored-by: Mike van Veenhuijzen <[email protected]> * fix(a11y): only set focus programmatically on keyboard navigation Co-authored-by: Mike van Veenhuijzen <[email protected]> * feat(a11y): form validation improvements for screen readers Co-authored-by: Mike van Veenhuijzen <[email protected]> * fix(a11y): apply aria-hidden to checkbox asterisk (#121) * feat(a11y): slide chevron buttons hitarea increased Co-authored-by: Mike van Veenhuijzen <[email protected]> * fix(a11y): usermenu item count & correct html structure Co-authored-by: Mike van Veenhuijzen <[email protected]> * fix(a11y): roles and aria-attributes regarding modals (#125) * feat(a11y): slider navigation optimized * chore: fix react warning * fix(payment): layout of invoices on mobile * fix(a11y): optimize footer for accessibility * feat(a11y): improve accessibility of sidebar * feat(a11y): optimize profile menu * fix(a11y): improve screenreader focus on start watching button * fix(a11y): videoplayer focus (iOS) & restoration Co-authored-by: Mike van Veenhuijzen <[email protected]> * fix: active state of language menu and apply aria-current * fix(search): prevent keyboard from persisting in searchbar on submit * fix(a11y): ensure correct focus on first sidebar menu item * fix(user): update question value while typing Co-authored-by: Mike van Veenhuijzen <[email protected]> * fix(videodetail): don’t render empty duration metadata * fix(user): error when updating customer * fix(project): checkbox values for customer consents * fix(menu): ensure sidebar is scrollable * refactor(menu): apply dynamic viewport height for sidebar * fix(project): overall styling of the hub page * fix(payment): fix new subscription not showing in UI * fix: cinema not covering full viewport height * fix(videodetail): page behind player too wide * fix(videodetail): buttons not aligning properly * feat: align sidebar backdrop with modal * fix(a11y): add selected state to season filters * fix(a11y): add role to make lock icon readable refactor(tests): update snapshots * fix(a11y): add aria-pressed to password icon and underline to footer links * fix: video metadata styling with status icon for live events * chore: format package files * fix(player): back button not working * fix(player): title overlay fade animation * chore(project): maintenance 2024-q1 * chore: enable verbatimModuleSyntax * chore: use cjs for lighthouse config * chore: add comment to s3 workflow * refactor: extract metadata utils * chore: cleanup translations --------- Co-authored-by: Vincent Couzij <[email protected]> Co-authored-by: Melissa Hart <[email protected]> Co-authored-by: Mike van Veenhuijzen <[email protected]> Co-authored-by: langemike <[email protected]> Co-authored-by: Roy Schut <[email protected]> Co-authored-by: Roy Schut <[email protected]> Co-authored-by: Melissa 't Hart <[email protected]>
- Loading branch information
8 people
authored
Mar 15, 2024
1 parent
69eff3c
commit 82b5967
Showing
227 changed files
with
4,143 additions
and
3,390 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: Web - Test - Deploy Preview and Lighthouse Test | ||
| name: Web - Test - PR Deploy Preview and Lighthouse Test | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
@@ -36,4 +36,4 @@ jobs: | |
| - name: Install Lighthouse CI | ||
| run: sudo yarn global add @lhci/[email protected] | ||
| - name: Run Lighthouse CI | ||
| run: lhci autorun --collect.url=${{ needs.build_and_preview.outputs.output1 }}?app-config=gnnuzabk --config=./lighthouserc.js | ||
| run: lhci autorun --collect.url=${{ needs.build_and_preview.outputs.output1 }}?app-config=gnnuzabk --config=./lighthouserc.cjs | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # Example workflow to deploy the web platform to an AWS S3 bucket on pull requests | ||
| # This workflow is disabled for the OTT Web App | ||
| # | ||
| # See | ||
| # - https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_access-keys.html | ||
| # - https://docs.aws.amazon.com/AmazonS3/latest/userguide/example-policies-s3.html#iam-policy-ex0 | ||
| # | ||
| # Create an environment named `Deployment Previews` or change the environment.name below | ||
| # | ||
| # Environment variables: | ||
| # - DEPLOYMENT_PREVIEWS - Set this any value to enable this workflow | ||
| # - AWS_ACCESS_KEY_ID - The AWS access key id | ||
| # - AWS_REGION - The AWS region where the bucket is created. Example `us-west-1` | ||
| # - CLOUDFRONT_ID - Optionally define the AWS Cloudfront ID to invalidate the cache after the build | ||
| # | ||
| # Environment secrets: | ||
| # - AWS_SECRET_ACCESS_KEY - The AWS secret access key | ||
|
|
||
| name: Web - Test - PR Deploy Preview | ||
| run-name: Deploy Preview - PR ${{ github.event.pull_request.number || '0' }} | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: ./platforms/web | ||
|
|
||
| jobs: | ||
| deploy: | ||
| name: Deploy | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| environment: | ||
| name: Deployment Previews | ||
| url: ${{ format('https://pr-{0}.{1}?app-config={2}', github.event.pull_request.number || '0' , vars.PREVIEW_DOMAIN, vars.PREVIEW_DEFAULT_CONFIG) }} | ||
| if: ${{ vars.DEPLOYMENT_PREVIEWS != '' }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| - name: Install packages | ||
| run: yarn install --frozen-lockfile | ||
| - name: Build | ||
| run: | | ||
| yarn build | ||
| env: | ||
| MODE: demo | ||
| APP_GTM_TAG_ID: ${{ vars.APP_GTM_TAG_ID }} | ||
| APP_FOOTER_TEXT: ${{ vars.APP_FOOTER_TEXT }} | ||
| APP_BODY_FONT_FAMILY: ${{ vars.APP_BODY_FONT_FAMILY }} | ||
| APP_BODY_ALT_FONT_FAMILY: ${{ vars.APP_BODY_ALT_FONT_FAMILY }} | ||
| APP_DEFAULT_CONFIG_SOURCE: ${{ vars.APP_DEFAULT_CONFIG_SOURCE }} | ||
| APP_PLAYER_LICENSE_KEY: ${{ vars.APP_PLAYER_LICENSE_KEY }} | ||
| - uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| aws-access-key-id: ${{ vars.AWS_ACCESS_KEY_ID }} | ||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: ${{ vars.AWS_REGION }} | ||
| - name: Copy dist files to S3 Bucket | ||
| run: | | ||
| aws s3 sync build/public s3://$BUCKET/$DIR --cache-control max-age=60 --delete | ||
| env: | ||
| BUCKET: ${{ vars.BUCKET }} | ||
| DIR: ${{ github.event.pull_request.number || '0' }} | ||
| - name: Set different cache control for index.html | ||
| run: | | ||
| aws s3 cp build/public/index.html s3://$BUCKET/$DIR/index.html --cache-control max-age=0,no-cache | ||
| env: | ||
| BUCKET: ${{ vars.BUCKET }} | ||
| DIR: ${{ github.event.pull_request.number || '0' }} | ||
| - name: Set different cache control for files in assets folder | ||
| run: | | ||
| aws s3 cp build/public/assets s3://$BUCKET/$DIR/assets --cache-control max-age=31536000 --recursive | ||
| env: | ||
| BUCKET: ${{ vars.BUCKET }} | ||
| DIR: ${{ github.event.pull_request.number || '0' }} | ||
| - name: Invalidate cloudfront distribution | ||
| if: ${{ vars.CLOUDFRONT_ID }} | ||
| run: aws cloudfront create-invalidation --distribution-id $CLOUDFRONT_ID --paths "/$DIR/images/*" "/$DIR/*.*" | ||
| env: | ||
| CLOUDFRONT_ID: ${{ vars.CLOUDFRONT_ID }} | ||
| DIR: ${{ github.event.pull_request.number || '0' }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,88 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/[email protected]/dist/schema.json", | ||
| "sortFirst": [ | ||
| "name", | ||
| "description", | ||
| "version", | ||
| "private", | ||
| "license", | ||
| "repository", | ||
| "author", | ||
| "main", | ||
| "exports", | ||
| "engines", | ||
| "workspaces", | ||
| "scripts" | ||
| ], | ||
| "semverGroups": [ | ||
| { | ||
| "dependencies": ["codeceptjs", "codeceptjs**", "react-router", "react-router-dom"], | ||
| "packages": ["**"], | ||
| "dependencies": [ | ||
| "codeceptjs", | ||
| "codeceptjs**", | ||
| "react-router", | ||
| "react-router-dom", | ||
| "typescript" | ||
| ], | ||
| "packages": [ | ||
| "**" | ||
| ], | ||
| "isIgnored": true | ||
| }, | ||
| { | ||
| "range": "^", | ||
| "dependencies": ["**"], | ||
| "packages": ["**"], | ||
| "dependencyTypes": ["prod", "dev", "peer", "resolutions"] | ||
| "dependencies": [ | ||
| "**" | ||
| ], | ||
| "packages": [ | ||
| "**" | ||
| ], | ||
| "dependencyTypes": [ | ||
| "prod", | ||
| "dev", | ||
| "peer" | ||
| ] | ||
| } | ||
| ], | ||
| "versionGroups": [ | ||
| { | ||
| "label": "Ensure semver ranges for locally developed packages satisfy the local version", | ||
| "dependencies": ["@jwp/**", "**-config-jwp"], | ||
| "dependencyTypes": ["peer"], | ||
| "packages": ["**"], | ||
| "dependencies": [ | ||
| "@jwp/**", | ||
| "**-config-jwp" | ||
| ], | ||
| "dependencyTypes": [ | ||
| "peer" | ||
| ], | ||
| "packages": [ | ||
| "**" | ||
| ], | ||
| "pinVersion": "*" | ||
| }, | ||
| { | ||
| "label": "Ensure local packages are installed as peerDependency", | ||
| "dependencies": ["@jwp/**", "**-config-jwp"], | ||
| "dependencyTypes": ["dev", "prod"], | ||
| "packages": ["**"], | ||
| "dependencies": [ | ||
| "@jwp/**", | ||
| "**-config-jwp" | ||
| ], | ||
| "dependencyTypes": [ | ||
| "dev", | ||
| "prod" | ||
| ], | ||
| "packages": [ | ||
| "**" | ||
| ], | ||
| "isBanned": true | ||
| }, | ||
| { | ||
| "dependencies": ["@types/**"], | ||
| "dependencyTypes": ["!dev"], | ||
| "packages": ["**"], | ||
| "dependencies": [ | ||
| "@types/**" | ||
| ], | ||
| "dependencyTypes": [ | ||
| "!dev" | ||
| ], | ||
| "packages": [ | ||
| "**" | ||
| ], | ||
| "isBanned": true, | ||
| "label": "@types packages should only be under devDependencies" | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.