Merge branch 'develop' into dbudzins/replace-depcheck

docs/features/user-watchlists.md

@@ -127,10 +127,16 @@ Example data format
 }
 ```
 
-### Max 48 items
+### Max amount of items
 
-Cleeng customer `externalData` attribute has maxsize of 5000 symbols.
+#### JWP
 
-The length of one stringified object of History equals to 52 symbols, one Favorites object equals to 22 symbols. Taking into account only History objects, we get 5000 / 52 = ~96, so 48 for Favorites and 48 for History. We also leave some extra space for possible further updates.
+For JWP the limit is 48 items for Favorites and 48 for Watch History.
+
+#### Cleeng
+
+Cleeng customer `externalData` attribute has maxsize of 4000 symbols.
+
+The length of one stringified object of History equals to 41 symbols, one Favorites object equals to 22 symbols. Taking into account only History objects, we get 4000 / 41 = ~97.56, so 48 for Favorites and 48 for Watch History. We also leave some extra space for possible further updates.
 
 We rotate the oldest continue watching object to the first item position after its progress property gets a new value.

packages/common/src/constants.ts

@@ -23,9 +23,6 @@ export const VideoProgressMinMax = {
 
 export const PLAYLIST_LIMIT = 25;
 
-// The externalData attribute of Cleeng can contain max 5000 characters
-export const MAX_WATCHLIST_ITEMS_COUNT = 48;
-
 export const ADYEN_TEST_CLIENT_KEY = 'test_I4OFGUUCEVB5TI222AS3N2Y2LY6PJM3K';
 
 export const ADYEN_LIVE_CLIENT_KEY = 'live_BQDOFBYTGZB3XKF62GBYSLPUJ4YW2TPL';
@@ -62,6 +59,8 @@ export const STALE_TIME = 60 * 1000 * 20;
 
 export const CARD_ASPECT_RATIOS = ['1:1', '2:1', '2:3', '4:3', '5:3', '16:9', '9:13', '9:16'] as const;
 
+export const MAX_WATCHLIST_ITEMS_COUNT = 48; // Default value
+
 export const DEFAULT_FEATURES = {
   canUpdateEmail: false,
   canSupportEmptyFullName: false,
@@ -73,6 +72,7 @@ export const DEFAULT_FEATURES = {
   canShowReceipts: false,
   hasSocialURLs: false,
   hasNotifications: false,
+  watchListSizeLimit: MAX_WATCHLIST_ITEMS_COUNT,
 };
 
 export const simultaneousLoginWarningKey = 'simultaneous_logins';

packages/common/src/controllers/FavoritesController.ts

@@ -74,7 +74,7 @@ export default class FavoritesController {
     }
 
     // If we exceed the max available number of favorites, we show a warning
-    if (this.favoritesService.hasReachedFavoritesLimit(favorites)) {
+    if (favorites.length > this.favoritesService.getMaxFavoritesCount()) {
       setWarning(i18next.t('video:favorites_warning', { maxCount: this.favoritesService.getMaxFavoritesCount() }));
       return;
     }

packages/common/src/services/FavoriteService.ts

@@ -1,13 +1,13 @@
 import { inject, injectable } from 'inversify';
 import { object, array, string } from 'yup';
 
-import { MAX_WATCHLIST_ITEMS_COUNT } from '../constants';
 import type { Favorite, SerializedFavorite } from '../../types/favorite';
 import type { PlaylistItem } from '../../types/playlist';
 import type { Customer } from '../../types/account';
 import { getNamedModule } from '../modules/container';
 import { INTEGRATION_TYPE } from '../modules/types';
 import { logDev } from '../utils/common';
+import { MAX_WATCHLIST_ITEMS_COUNT } from '../constants';
 
 import ApiService from './ApiService';
 import StorageService from './StorageService';
@@ -21,7 +21,6 @@ const schema = array(
 
 @injectable()
 export default class FavoriteService {
-  private MAX_FAVORITES_COUNT = 48;
   private PERSIST_KEY_FAVORITES = 'favorites';
 
   private readonly apiService;
@@ -89,11 +88,7 @@ export default class FavoriteService {
   };
 
   getMaxFavoritesCount = () => {
-    return this.MAX_FAVORITES_COUNT;
-  };
-
-  hasReachedFavoritesLimit = (favorites: Favorite[]) => {
-    return favorites?.length >= MAX_WATCHLIST_ITEMS_COUNT;
+    return this.accountService?.features?.watchListSizeLimit || MAX_WATCHLIST_ITEMS_COUNT;
   };
 
   createFavorite = (item: PlaylistItem): Favorite => {

packages/common/src/services/WatchHistoryService.ts

@@ -7,6 +7,7 @@ import type { Customer } from '../../types/account';
 import { getNamedModule } from '../modules/container';
 import { INTEGRATION_TYPE } from '../modules/types';
 import { logDev } from '../utils/common';
+import { MAX_WATCHLIST_ITEMS_COUNT } from '../constants';
 
 import ApiService from './ApiService';
 import StorageService from './StorageService';
@@ -22,7 +23,6 @@ const schema = array(
 @injectable()
 export default class WatchHistoryService {
   private PERSIST_KEY_WATCH_HISTORY = 'history';
-  private MAX_WATCH_HISTORY_COUNT = 48;
 
   private readonly apiService;
   private readonly storageService;
@@ -145,6 +145,10 @@ export default class WatchHistoryService {
     } as WatchHistoryItem;
   };
 
+  getMaxWatchHistoryCount = () => {
+    return this.accountService?.features?.watchListSizeLimit || MAX_WATCHLIST_ITEMS_COUNT;
+  };
+
   /**
    *  If we already have an element with continue watching state, we:
    *    1. Update the progress
@@ -163,8 +167,7 @@ export default class WatchHistoryService {
     });
 
     updatedHistory.unshift(watchHistoryItem);
-
-    updatedHistory.splice(this.MAX_WATCH_HISTORY_COUNT);
+    updatedHistory.splice(this.getMaxWatchHistoryCount());
 
     return updatedHistory;
   };

packages/common/src/services/integrations/AccountService.ts

@@ -35,6 +35,7 @@ export type AccountServiceFeatures = {
   readonly canShowReceipts: boolean;
   readonly hasSocialURLs: boolean;
   readonly hasNotifications: boolean;
+  readonly watchListSizeLimit: number;
 };
 
 export default abstract class AccountService {

packages/common/src/services/integrations/cleeng/CleengAccountService.ts

@@ -68,9 +68,11 @@ export default class CleengAccountService extends AccountService {
       canExportAccountData: false,
       canDeleteAccount: false,
       canUpdatePaymentMethod: true,
-      canShowReceipts: true,
+      canShowReceipts: false,
       hasSocialURLs: false,
       hasNotifications: false,
+      // The 'externalData' attribute of Cleeng can contain max 4000 characters
+      watchListSizeLimit: 48,
     });
 
     this.cleengService = cleengService;

packages/common/src/services/integrations/jwp/JWPAccountService.ts

@@ -68,6 +68,8 @@ export default class JWPAccountService extends AccountService {
       canDeleteAccount: true,
       hasNotifications: true,
       hasSocialURLs: true,
+      // Limit of media_ids length passed to the /apps/watchlists endpoint
+      watchListSizeLimit: 48,
     });
 
     this.storageService = storageService;

packages/hooks-react/src/useWatchHistoryListener.ts

@@ -57,7 +57,7 @@ export const useWatchHistoryListener = (player: jwplayer.JWPlayer | undefined, i
     // live streams have a negative duration, we ignore these for now
     if (event.duration < 0) return;
 
-    const progress = event.position / event.duration;
+    const progress = Number((event.position / event.duration).toFixed(5));
 
     if (!isNaN(progress) && isFinite(progress)) {
       queuedWatchProgress.current = {