[JW8-12117] Update custom receiver app #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dawolee
requested review from
zetagame,
mamaddox,
imbcmdth,
jdunningjwp and
jwbrandon
|
✅ Build for commit ea093b0 passed. Take it for a spin https://jenkins-player.longtailvideo.com/job/jw7-pr-builder-cast-receiver/35/artifact/bin-debug/index.html?key=2BZ0H4uA%2B%2F7xZb0rKQSQ%2B6K%2FFZcUxEJbgZTEsQ%3D%3D 🎮 On! |
Dawolee
changed the title
Dawolee
commented
Mar 28, 2022
|
|
||
| // Start listening for messages. | ||
| // https://developers.google.com/cast/docs/web_receiver/core_features following CAF changes | ||
| this.playerManager.addEventListener(EventType.ALL, this.dispatchEvent.bind(this)); |
There was a problem hiding this comment.
was setting this to ALL for debugging but we should listen to specific events for the actual app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Update this repo's older dependencies and build scripts. Also refactored some logic and updated cast receiver syntax as we are migrating to Web Receiver v3 https://developers.google.com/cast/docs/migrate_v2/receiver.
General list of things I did with this PR:
Although I tried to fix a lot of the basic core functionality, such as being able to control playback with the sender app player, there are still issues that need to be addressed such as:
jwplayer().getPosition()on the jwplayer in the web receiver app and the jwplayer on Desktop web app starting the cast session and they returned different values). This does not affect the controls (pause, play, volume setting, next playlist item, etc) but the time being out of sync seems to cause the sender app player to show a buffering state quite often. This might be something we have to adjust on our sender app side??Why is this Pull Request needed?
Spike ticket
Are there any points in the code the reviewer needs to double check?
Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
https://jwplayer.atlassian.net/browse/JW8-12117