Production feedback #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script can fail in such a way that it does not write a cursor, but has created a log stream. In this case, creating a log stream a second time will fail. This can be easily ignored.
Uses an install strongly borrowing from the postgres official arch package. This creates a user and configures directory permissions for it. Without this, the /var/ state directory that tail-journald uses is not writable for the script.
The contained cfn-signal is required for performing rolling changes to launch configurations. Without cfn-signal you will not know when the host has launched successfully and completely.
This brings the log length limit up to the same as CloudWatch's own of 1048576, as opposed to the linux command line limit of MAX_ARG_STRLEN.
|
Is there any update on getting this merged? |
malcolmsparks
force-pushed
the
master
branch
2 times, most recently
from
a6c9c6a
to
c43ebe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
bac4641 (Dominic Monroe, 5 days ago)
Add aws-cfn-bootstrap package
The contained cfn-signal is required for performing rolling changes to
launch configurations. Without cfn-signal you will not know when the host
has launched successfully and completely.
98e1993 (Dominic Monroe, 2 weeks ago)
Fix permissions for cloudwatch script
Uses an install strongly borrowing from the postgres official arch package.
This creates a user and configures directory permissions for it. Without
this, the /var/ state directory that tail-journald uses is not writable for
the script.
48b89c0 (Dominic Monroe, 2 weeks ago)
Ignore failure when creating log-stream
The script can fail in such a way that it does not write a cursor, but has
created a log stream. In this case, creating a log stream a second time
will fail. This can be easily ignored.
58182bd (Dominic Monroe, 7 weeks ago)
Enable journald cloud watch script by default