Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle #160

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jennifer-ha
Copy link

Upgraded Android Gradle Plugin: Moved from AGP version 4.1.0 to 7.0.0. This upgrade allows us to take advantage of the latest features, performance improvements, and bug fixes introduced in recent AGP releases.

Namespace Specification: Added the namespace declaration in the build.gradle file to comply with the new AGP requirements. This ensures our project adheres to the latest Android build standards.

Repository Migration: Transitioned from jcenter() to mavenCentral() for fetching dependencies. This change is in response to the deprecation of JCenter as a repository, ensuring our project dependencies are fetched from a reliable and updated source.

Upgraded Android Gradle Plugin: Moved from AGP version 4.1.0 to 7.0.0. This upgrade allows us to take advantage of the latest features, performance improvements, and bug fixes introduced in recent AGP releases.
Namespace Specification: Added the namespace declaration in the build.gradle file to comply with the new AGP requirements. This ensures our project adheres to the latest Android build standards.
Repository Migration: Transitioned from jcenter() to mavenCentral() for fetching dependencies. This change is in response to the deprecation of JCenter as a repository, ensuring our project dependencies are fetched from a reliable and updated source.
Upgraded Android Gradle Plugin: Moved from AGP version 4.1.0 to 7.0.0. This upgrade allows us to take advantage of the latest features, performance improvements, and bug fixes introduced in recent AGP releases.
Namespace Specification: Added the namespace declaration in the build.gradle file to comply with the new AGP requirements. This ensures our project adheres to the latest Android build standards.
Repository Migration: Transitioned from jcenter() to mavenCentral() for fetching dependencies. This change is in response to the deprecation of JCenter as a repository, ensuring our project dependencies are fetched from a reliable and updated source.
add if (project.android.hasProperty("namespace")) {
required String thumbnailPath,
classpath 'com.android.tools.build:gradle:7.1.2'
@bugrevealingbme
Copy link

please approve

@mkobuolys
Copy link

Any plans to merge this any time soon?

@@ -27,7 +27,7 @@ class VideoThumbnail {
static Future<String?> thumbnailFile(
{required String video,
Map<String, String>? headers,
String? thumbnailPath,
required String thumbnailPath,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is now required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think you can skip this change for now. The modifications in build.gradle are essential.

@dharambudh1
Copy link

@justsoft, please take a moment to review and approve these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants