Update build.gradle #160
Open
Update build.gradle #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded Android Gradle Plugin: Moved from AGP version 4.1.0 to 7.0.0. This upgrade allows us to take advantage of the latest features, performance improvements, and bug fixes introduced in recent AGP releases. Namespace Specification: Added the namespace declaration in the build.gradle file to comply with the new AGP requirements. This ensures our project adheres to the latest Android build standards. Repository Migration: Transitioned from jcenter() to mavenCentral() for fetching dependencies. This change is in response to the deprecation of JCenter as a repository, ensuring our project dependencies are fetched from a reliable and updated source.
Upgraded Android Gradle Plugin: Moved from AGP version 4.1.0 to 7.0.0. This upgrade allows us to take advantage of the latest features, performance improvements, and bug fixes introduced in recent AGP releases. Namespace Specification: Added the namespace declaration in the build.gradle file to comply with the new AGP requirements. This ensures our project adheres to the latest Android build standards. Repository Migration: Transitioned from jcenter() to mavenCentral() for fetching dependencies. This change is in response to the deprecation of JCenter as a repository, ensuring our project dependencies are fetched from a reliable and updated source.
add if (project.android.hasProperty("namespace")) {
required String thumbnailPath,
classpath 'com.android.tools.build:gradle:7.1.2'
|
please approve |
|
Any plans to merge this any time soon? |
jxstxn1
reviewed
Apr 10, 2024
| @@ -27,7 +27,7 @@ class VideoThumbnail { | |||
| static Future<String?> thumbnailFile( | |||
| {required String video, | |||
| Map<String, String>? headers, | |||
| String? thumbnailPath, | |||
| required String thumbnailPath, | |||
There was a problem hiding this comment.
Hi, I think you can skip this change for now. The modifications in build.gradle are essential.
|
@justsoft, please take a moment to review and approve these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded Android Gradle Plugin: Moved from AGP version 4.1.0 to 7.0.0. This upgrade allows us to take advantage of the latest features, performance improvements, and bug fixes introduced in recent AGP releases.
Namespace Specification: Added the namespace declaration in the build.gradle file to comply with the new AGP requirements. This ensures our project adheres to the latest Android build standards.
Repository Migration: Transitioned from jcenter() to mavenCentral() for fetching dependencies. This change is in response to the deprecation of JCenter as a repository, ensuring our project dependencies are fetched from a reliable and updated source.