-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of Concept: Monitor Component bundle sizes #2005
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good thanks for putting this together. My only nitpick is I wonder if we could have all the config in 1 file per component and not 2. But other than that looks like a good approach 👍
Describe your changes (can list changeset entries if preferable)
Allows us to set max limits (in KB) for each of our components, and runs a CI check that fails if any exceed the limits. If they do, all components will be mentioned in a PR comment which contains the failures in a table. It also logs out the gzip and brotli compressed sizes.
I wrote the package to prototype it quickly however there's no reason we can't fork it and move into the monorepo if we wish.
CI Behaviour:
Illustrations:
The new CI steps (only run on the Ubuntu Node 20 build)
When all components pass
PR Comment left when components fail
CI logs when a component fails