Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint-config-pie): DSW-2294 upgrade eslint to v9 #2004

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Oct 18, 2024

Describe your changes (can list changeset entries if preferable)

  • Upgrade eslint to v9
    • Remove .eslintignore files (replace in new config format, if required?)
    • Reformat .eslintrc.js files to flat eslint.config.js format.
      • We may be able to do a partial migration to start with, by disabling flat config files?

  • Waiting on Airbnb to support v9
  • Update example apps (currently untested)
  • Make sure unit tests are correct (likely need to wait for Airbnb config to be updated)
  • Fix unit tests for strict config
  • Fix framework (Vue) exports
  • Make sure all eslint-disable comments are still needed (I think you can add a linting rule for this?)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: d9a5c5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant