Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-toast-provider): DSW-2222 add toast provider to apps #228

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

raoufswe
Copy link
Member

adds toast and toast provider examples to different apps

@raoufswe raoufswe force-pushed the dsw-2222-add-toast-provider branch from d8a7a4d to a86623d Compare January 9, 2025 09:13
@siggerzz
Copy link
Contributor

siggerzz commented Jan 9, 2025

Just need to update these files. 👍🏼

Given that some page interaction is required for pie-toast-provider, feel free to just add pie-toast to these files, and create a new JIRA ticket to add the required tests for the toast provider

https://github.com/justeattakeaway/pie-aperture/blob/main/nextjs-app-v14/test/visual/nextjs.spec.js
https://github.com/justeattakeaway/pie-aperture/blob/main/nuxt-app/test/visual/nuxt.spec.js
https://github.com/justeattakeaway/pie-aperture/blob/main/vanilla-app/test/visual/vanilla.spec.js

@raoufswe raoufswe merged commit 7e5dec5 into main Jan 9, 2025
16 checks passed
@raoufswe raoufswe deleted the dsw-2222-add-toast-provider branch January 9, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants