Add Publisher TopicAddress customizer #1625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the build script to enable local runs against localstack using either docker or podman as the container runner command
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 78.56% 78.55% -0.01%
==========================================
Files 141 144 +3
Lines 3550 3638 +88
Branches 501 507 +6
==========================================
+ Hits 2789 2858 +69
- Misses 512 527 +15
- Partials 249 253 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
samples/src/JustSaying.Sample.Restaurant.OrderingApi/Program.cs
Outdated
Show resolved
Hide resolved
| private readonly string _topicArnTemplate = topicArnTemplate; | ||
| private readonly ConcurrentDictionary<string, IMessagePublisher> _publisherCache = new(); | ||
| private readonly ConcurrentDictionary<string, IMessageBatchPublisher> _batchPublisherCache = new(); | ||
| private readonly ConcurrentDictionary<string, SemaphoreSlim> _topicCreationLocks = new(); |
There was a problem hiding this comment.
Are we OK with these never being disposed?
There was a problem hiding this comment.
I think given Publishers tend to last the lifetime of the application, it should be okay.
To make sure unmanaged resources get cleaned up, SemaphoreSlim also (transiently) uses a SafeHandle, which will also cleanup on finalize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required APIs and internals for allowing a publisher to be configured that uses message content to determine the topic ARN to publish to.