Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: update to Angular 19 #1871

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore(deps)!: update to Angular 19 #1871

merged 1 commit into from
Dec 5, 2024

Conversation

arturovt
Copy link
Collaborator

No description provided.

@arturovt arturovt force-pushed the chore/ng19 branch 4 times, most recently from f856d38 to ffac768 Compare November 22, 2024 14:32
@arturovt arturovt linked an issue Nov 22, 2024 that may be closed by this pull request
@arturovt arturovt force-pushed the chore/ng19 branch 2 times, most recently from c71f014 to 451b05b Compare November 26, 2024 15:46
@arturovt arturovt requested a review from just-jeb November 26, 2024 15:59
@arturovt arturovt marked this pull request as ready for review November 26, 2024 15:59
Copy link
Owner

@just-jeb just-jeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, one concern, should we merge #1860 into v19 update (as a breaking change)?
We can also merge the current PR as is but keep it in beta until we merge the breaking changes.
@arturovt wdyt?

@arturovt
Copy link
Collaborator Author

We can merge those breaking changes first and I will rebase this branch later.

@mshima
Copy link

mshima commented Nov 28, 2024

Hi, thanks to your work.

Unless a new v18 release is planned I think the v19 migration should be merged before.

  • those breaking changes seems to be only related to custom-esbuild which have limited usage.
  • this PR is much broader than the custom-esbuild only changes.
  • this PR is ready and will allow betas or even a final version of packages except esbuild like happened with jest in the past.

@just-jeb
Copy link
Owner

just-jeb commented Dec 4, 2024

@arturovt I agree with @mshima, especially taking into account that #1860 may cause breaking changes.

@LanderBeeuwsaert
Copy link

It would be nice to get this merged. This is the only package blocking us (and I can imagine that there are other projects in the same situation) from moving to angular 19.

@p1n5u
Copy link

p1n5u commented Dec 5, 2024

Is there any timeline for the release of this update? we are in the same position as @LanderBeeuwsaert and this is the only package that is blocking the migration to angular 19.

@arturovt
Copy link
Collaborator Author

arturovt commented Dec 5, 2024

@arturovt I agree with @mshima, especially taking into account that #1860 may cause breaking changes.

Ok, lemme rebase and let it go

@just-jeb just-jeb merged commit d3b17ed into master Dec 5, 2024
1 check passed
@just-jeb just-jeb deleted the chore/ng19 branch December 5, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Angular 19
8 participants