fix: using schema_name in redis key #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahatoankitkumar
approved these changes
Jan 24, 2025
ayushjain17
reviewed
Jan 24, 2025
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "8e28bdad6db2b8340e449f7108f020b3b092e8583a9e3fb82713e1d4e71fe817" | ||
| checksum = "d6b6f7f2fcb69f747921f79f3926bd1e203fce4fef62c268dd3abfb6d86029aa" |
There was a problem hiding this comment.
do we need cargo lock change for this ?
There was a problem hiding this comment.
It made the change after I compiled with high-performance-mode flag
|
Is this causing a compilation failure? |
|
@ShreyBana it will if you do |
ayushjain17
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The variable schema_name is de-referenced only once, doing it twice grants access to the string it's wrapping
Solution
De-reference twice