Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add success alerts and remove divider #380

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mahatoankitkumar
Copy link
Collaborator

Problem

Describe the problem you are trying to solve here

Solution

Provide a brief summary of your solution so that reviewers can understand your code

Environment variable changes

What ENVs need to be added or changed

Pre-deployment activity

Things needed to be done before deploying this change (if any)

Post-deployment activity

Things needed to be done after deploying this change (if any)

API changes

Endpoint Method Request body Response Body
API GET/POST, etc request response

Possible Issues in the future

Describe any possible issues that could occur because of this change

@mahatoankitkumar mahatoankitkumar requested a review from a team as a code owner January 23, 2025 05:36
@Datron Datron force-pushed the fix/add-enqueue-alerts branch from a01761d to 9f783d9 Compare January 23, 2025 10:24
@ShubhranshuSanjeev
Copy link
Collaborator

ShubhranshuSanjeev commented Jan 23, 2025

Screen.Recording.2025-01-23.at.4.59.26.PM.mov

@mahatoankitkumar , this might be out of this PRs scope, but create dimensions is failing. Possible to check.

False alarm, failures stopped after re-starting containers, might be some problem with local state.

@ShubhranshuSanjeev ShubhranshuSanjeev merged commit 8b12e6b into saas Jan 23, 2025
4 checks passed
@ShubhranshuSanjeev ShubhranshuSanjeev deleted the fix/add-enqueue-alerts branch January 23, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants