refactor: workspace ui & form #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahatoankitkumar
approved these changes
Jan 22, 2025
ayushjain17
requested changes
Jan 22, 2025
| @@ -1,4 +1,5 @@ | |||
| #![deny(unused_crate_dependencies)] | |||
| pub mod api; | |||
There was a problem hiding this comment.
lets put this file behind a cfg
| @@ -164,14 +159,15 @@ where | |||
| <label class="label"> | |||
| <span class="label-text">Workspace Status</span> | |||
| </label> | |||
| <BooleanToggle | |||
There was a problem hiding this comment.
can we remove BooleanToggle altogether if its no longer meant to be used in any place ?
| @@ -72,7 +67,7 @@ where | |||
|
|
|||
| match result { | |||
| Ok(_) => { | |||
| handle_submit(); | |||
| handle_submit.call(()); | |||
There was a problem hiding this comment.
is this change needed because the type is being changed from NF to Callback ?
Comment on lines
+1
to
+17
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| use crate::database::models::WorkspaceStatus; | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| pub struct CreateWorkspaceRequest { | ||
| pub workspace_admin_email: String, | ||
| pub workspace_name: String, | ||
| pub workspace_status: Option<WorkspaceStatus>, | ||
| } | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| pub struct UpdateWorkspaceRequest { | ||
| pub workspace_admin_email: String, | ||
| pub workspace_status: Option<WorkspaceStatus>, | ||
| pub mandatory_dimensions: Option<Vec<String>>, | ||
| } |
There was a problem hiding this comment.
since this has been created, can we reuse it in context-aware-config crate in this PR itself and remove the type repetition from that crate as well
ShubhranshuSanjeev
force-pushed
the
refactor/workspace-ui
branch
from
2132cbe to
a2cbafc
Compare
ayushjain17
approved these changes
Jan 23, 2025
Datron
pushed a commit
that referenced
this pull request
Jan 23, 2025
* refactor: workspace ui & form * refactor: moved api types behind feature flag
Datron
pushed a commit
that referenced
this pull request
Jan 23, 2025
* refactor: workspace ui & form * refactor: moved api types behind feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368