fix: resolve page failing when any type other than string is used for a value #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
force-pushed
the
fix-resolve
branch
3 times, most recently
from
be388ce to
c7df168
Compare
- Also convert value in some places to use textarea instead of input
ShubhranshuSanjeev
approved these changes
May 3, 2024
mahatoankitkumar
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolve page doesn't resolve when the type of a value is not a string because the code was trying convert everything to string.
Solution
Properly parse types and display them so that the resolve UI works correctly. Also replace
<input>for values in some places withtextarea