Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned module architecture #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Redesigned module architecture #6

wants to merge 9 commits into from

Commits on Dec 5, 2013

  1. fixed one last indentation left behind

    @marcelo-lipienski
    marcelo-lipienski committed Dec 5, 2013
    Configuration menu
    Copy the full SHA
    88cf042 View commit details
    Browse the repository at this point in the history

  2. ignore phpstorm settings directory

    @marcelo-lipienski
    marcelo-lipienski committed Dec 5, 2013
    Configuration menu
    Copy the full SHA
    113ab46 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master'

    @marcelo-lipienski
    marcelo-lipienski committed Dec 5, 2013
    Configuration menu
    Copy the full SHA
    c7757de View commit details
    Browse the repository at this point in the history

  4. Moved caching logic to CacheService and left event listeners in Cache… 

    …Listener.

Tests are now divided as well.
    @marcelo-lipienski
    marcelo-lipienski committed Dec 5, 2013
    Configuration menu
    Copy the full SHA
    e0858bb View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2013

  1. Added CacheFactory and updated module.config to rely upon the factory… 

    … instead of a closure
    @marcelo-lipienski
    marcelo-lipienski committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    599baf6 View commit details
    Browse the repository at this point in the history

  2. Added ListenerFactory and passing tests

    @marcelo-lipienski
    marcelo-lipienski committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    0e8e383 View commit details
    Browse the repository at this point in the history

  3. Removed new lines I mistakenly added, so now code matches original one

    @marcelo-lipienski
    marcelo-lipienski committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    d4c0dc1 View commit details
    Browse the repository at this point in the history

  4. removed my personal .gitignore

    @marcelo-lipienski
    marcelo-lipienski committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    2e0b355 View commit details
    Browse the repository at this point in the history

  5. added copyright information

    @marcelo-lipienski
    marcelo-lipienski committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    84397b1 View commit details
    Browse the repository at this point in the history