Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test link in documentation #10

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Sep 14, 2023

The test link in documentation is not properly parsed by my_st parser, the & are replaced with &, which seems to break the search params.

@github-actions
Copy link

Binder 👈 Launch a Binder on branch brichet/litegitpuller/fix_test_link

@jtpio
Copy link
Member

jtpio commented Sep 14, 2023

Hmm the build error is also happening on #9.

@brichet
Copy link
Collaborator Author

brichet commented Sep 14, 2023

Hmm the build error is also happening on #9.

Probably related to https://github.com/microsoft/playwright/releases/tag/v1.38.0, the one used in this test and in #9.
Some other packages may be affected too...

@jtpio
Copy link
Member

jtpio commented Sep 14, 2023

Ah this may be related to the latest Playwright release: https://github.com/microsoft/playwright/releases/tag/v1.38.0

@brichet
Copy link
Collaborator Author

brichet commented Sep 14, 2023

The link issue seems to be a my_st parser issue executablebooks/MyST-Parser#760

@brichet brichet marked this pull request as ready for review September 14, 2023 14:17
@brichet brichet requested a review from jtpio September 14, 2023 14:18
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 1b00117 into jupyterlite:main Sep 14, 2023
@brichet brichet deleted the fix_test_link branch September 14, 2023 14:40
@brichet brichet added the documentation Improvements or additions to documentation label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants