Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise informative error when ruamel.yaml is missing due to ruamel_yaml #51

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 27, 2020

conda ruamel_yaml fork can prevent pip installing ruamel.yaml dependency, so raise an informative error about how to fix this when it (probably) occurs.

alternative to #48 which tries to use the forked package instead.

Since there's a clear, easy workaround for conda and the bug is in the conda ruamel_yaml package (hopefully fixed in the future by conda-forge/ruamel_yaml-feedstock#68), I think this informative error which tells you exactly how to fix the problem is preferable to using the different package, which can come with its own issues over time.

closes #48

conda ruamel_yaml fork can prevent pip installing ruamel.yaml dependency,
raise an informative error about how to fix this when it (probably) occurs
@yuvipanda yuvipanda merged commit e76585d into jupyter:master Aug 27, 2020
@yuvipanda
Copy link
Collaborator

I like this one! Thanks, @minrk

@minrk minrk deleted the ruamel-hint branch August 27, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants