Skip to content

Commit

Permalink
Update dev-install and package.json so dev installs work.
Browse files Browse the repository at this point in the history
It was important to change the workspaces in package.json to point to the new locations so that yarn/lerna could find the new locations.

I also updated the dev-install.sh to be consistent with how it was installing each python package.
  • Loading branch information
jasongrout committed Nov 2, 2021
1 parent 4a71e7a commit da2542c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
9 changes: 3 additions & 6 deletions dev-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,19 @@ yarn install
yarn run build

echo -n "widgetsnbextension"
cd widgetsnbextension
pip install -v -e .
pip install -v -e ./python/widgetsnbextension
if [[ "$OSTYPE" == "msys" ]]; then
jupyter nbextension install --overwrite --py $nbExtFlags widgetsnbextension
else
jupyter nbextension install --overwrite --py --symlink $nbExtFlags widgetsnbextension
fi
jupyter nbextension enable --py $nbExtFlags widgetsnbextension
cd ../..

echo -n "ipywidgets"
cd python/ipywidgets
pip install -v -e ".[test]"
cd ../..
pip install -v -e "./python/ipywidgets[test]"

if test "$skip_jupyter_lab" != yes; then
echo -n "jupyterlab_ipywidgets"
pip install jupyter_packaging
pip install -ve ./python/jupyterlab_widgets
jupyter labextension develop ./python/jupyterlab_widgets --overwrite
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"private": true,
"workspaces": [
"packages/*",
"widgetsnbextension",
"python/widgetsnbextension",
"examples/*",
"jupyterlab_widgets"
"python/jupyterlab_widgets"
],
"scripts": {
"build": "lerna run build --ignore \"@jupyter-widgets/example-*\"",
Expand Down

0 comments on commit da2542c

Please sign in to comment.