Implement Lease controller #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCao
force-pushed
the
lease-controller
branch
from
0c78b47 to
24aebe2
Compare
NickCao
force-pushed
the
lease-controller
branch
from
24aebe2 to
6540017
Compare
mangelajo
reviewed
Aug 20, 2024
mangelajo
reviewed
Aug 20, 2024
NickCao
force-pushed
the
lease-controller
branch
from
009e5b3 to
78bf948
Compare
|
Depends on jumpstarter-dev/jumpstarter-protocol#6 |
prealloc golang linter produces harder to read code, the proposal is always an optimization that would make sense on big loops or big structurers but makes little difference for small things.
mangelajo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.