Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update attribute controls for xpress-9.4 #273

Merged
merged 3 commits into from
Jul 31, 2024
Merged

update attribute controls for xpress-9.4 #273

merged 3 commits into from
Jul 31, 2024

Conversation

mbataillou
Copy link
Contributor

@mbataillou mbataillou commented Jul 31, 2024 •
edited by odow
Loading

Ran the build_param_control_dicts.jl script and kept old parameters for compatibility.

Closes #272

@mbataillou mbataillou mentioned this pull request Jul 31, 2024
Closed
odow
odow reviewed Jul 31, 2024
View reviewed changes
src/attributes_controls.jl Outdated Show resolved Hide resolved
odow
odow reviewed Jul 31, 2024
View reviewed changes
src/attributes_controls.jl Outdated Show resolved Hide resolved
odow
odow reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the constants at the bottom of https://github.com/jump-dev/Xpress.jl/blob/master/src/Lib/xprs.jl

mbataillou
mbataillou commented Jul 31, 2024
View reviewed changes
Copy link
Contributor Author

@mbataillou mbataillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the license back and fixed format.

@mbataillou
Copy link
Contributor Author

Added the license back and fixed format.

We also need to update the constants at the bottom of https://github.com/jump-dev/Xpress.jl/blob/master/src/Lib/xprs.jl

Updated that in the last commit. Tell me if I missed anything!

odow
odow approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odow odow merged commit 60ae1dd into jump-dev:master Jul 31, 2024
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unrecognized control parameter.
2 participants
@mbataillou @odow