-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mk/rational arithmetic #141
Open
kalmarek
wants to merge
10
commits into
jump-dev:master
Choose a base branch
from
kalmarek:mk/rational_arithmetic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh, fuck; I had old version of MA in dev ;/ |
:( This is my fault sorry. I thought it was safe to clean things up because there were no open PRs! |
kalmarek
force-pushed
the
mk/rational_arithmetic
branch
from
February 7, 2022 09:45
0a8d40c
to
46384f6
Compare
kalmarek
force-pushed
the
mk/rational_arithmetic
branch
from
February 7, 2022 09:53
46384f6
to
e3268b4
Compare
ok, this looks ready from my side; notable change:
unfortunately I'm seeing quite some of scalar_uniform_scaling: Test Failed at /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6
Expression: MA.isequal_canonical(#= /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6 =# MA.@rewrite((x + 1) + I), (x + 1) + I) in |
Hi. Is there any update on merging this? Better division support would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.